magento/magento2#39948: Magento_Persistent performance overhead on non-cart, non-checkout pages by KrasnoshchokBohdan · Pull Request #39967 · magento/magento2

KrasnoshchokBohdan · 2025-06-06T08:24:19Z

new QuoteResourceWrapper class that uses direct SQL queries instead of loading the entire quote object, which should improve performance

Description (*)

I decided to test the solution proposed by the author. It turned out that the changes reduced the execution time of CheckExpirePersistentQuoteObserver from ~52ms to less than 1ms.
Before

After

So I make this pull request to initiate further discussion.

Related Pull Requests

Fixed Issues (if relevant)

Fixes Magento_Persistent performance overhead on non-cart, non-checkout pages #39948

Manual testing scenarios (*)

Add product to cart (for example from PLP)
Enter PDP with profiler enabled

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)

…on-checkout pages - new QuoteResourceWrapper class that uses direct SQL queries instead of loading the entire quote object, which should improve performance

m2-assistant · 2025-06-06T08:24:23Z

Hi @KrasnoshchokBohdan. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

KrasnoshchokBohdan · 2025-06-06T08:25:39Z

@magento run all tests

…on-checkout pages - static tests fix

…on-checkout pages - unit tests

…r-issue-39948

KrasnoshchokBohdan · 2025-06-06T14:00:02Z

@magento run all tests

…on-checkout pages - static tests

KrasnoshchokBohdan · 2025-06-07T07:25:27Z

@magento run Static Tests

KrasnoshchokBohdan · 2025-06-07T16:36:13Z

@magento run Database Compare, Functional Tests B2B, Functional Tests CE, Functional Tests EE, Integration Tests, Magento Health Index, Sample Data Tests B2B, Sample Data Tests CE, Sample Data Tests EE, Semantic Version Checker, Unit Tests, WebAPI Tests

Copilot

Pull Request Overview

This PR introduces a new QuoteResourceWrapper to optimize persistent quote checks via direct SQL queries and updates the CheckExpirePersistentQuoteObserver (and its tests) to use it instead of loading full quote models.

Add QuoteResourceWrapper with isActive and isPersistent methods
Refactor CheckExpirePersistentQuoteObserver to use the new wrapper and remove model loading
Update unit tests to cover both the observer and the wrapper

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
app/code/Magento/Persistent/Model/QuoteResourceWrapper.php	New resource wrapper for efficient SQL-based quote queries
app/code/Magento/Persistent/Observer/CheckExpirePersistentQuoteObserver.php	Refactor observer to use `QuoteResourceWrapper`
app/code/Magento/Persistent/Test/Unit/Model/QuoteResourceWrapperTest.php	Unit tests for `QuoteResourceWrapper`
app/code/Magento/Persistent/Test/Unit/Observer/CheckExpirePersistentQuoteObserverTest.php	Updated observer tests to mock the new wrapper

Comments suppressed due to low confidence (5)

app/code/Magento/Persistent/Observer/CheckExpirePersistentQuoteObserver.php:77

[nitpick] Matching the checkout page by the raw string 'checkout' may unintentionally match other URLs. Consider using a more precise route or configuration-based constant for clarity and robustness.

    private $checkoutPagePath = 'checkout';

app/code/Magento/Persistent/Observer/CheckExpirePersistentQuoteObserver.php:25

[nitpick] Property naming is inconsistent: some fields use underscore prefixes (e.g., $_customerSession) while others (e.g., $request) use camelCase without prefixes. Standardize on a single naming convention to improve readability.

    protected $_customerSession;

app/code/Magento/Persistent/Observer/CheckExpirePersistentQuoteObserver.php:3

The copyright year 2015 appears outdated compared to other files (which use 2025). Please update it for consistency.

* Copyright 2015 Adobe

app/code/Magento/Persistent/Test/Unit/Model/QuoteResourceWrapperTest.php:204

[nitpick] In testIsPersistentTypeCasting, consider adding a with('quote') expectation on getTableName to ensure the correct table is used in the query.

$this->resourceConnectionMock->expects($this->once())->method('getTableName')->willReturn($tableName);

app/code/Magento/Persistent/Test/Unit/Observer/CheckExpirePersistentQuoteObserverTest.php:123

[nitpick] The test uses an integer 10 for the quote ID. Ensure consistent use of integer IDs across all tests to avoid potential type mismatches.

$quoteId = 10;

Copilot · 2025-06-11T09:10:33Z

+        $this->quoteResourceWrapper = $quoteResourceWrapper ?: ObjectManager::getInstance()
+            ->get(QuoteResourceWrapper::class);


Direct use of ObjectManager is discouraged. Consider injecting QuoteResourceWrapper via constructor dependency injection (with a default null and fallback) to improve testability and adhere to best practices.

Suggested change

$this->quoteResourceWrapper = $quoteResourceWrapper ?: ObjectManager::getInstance()

->get(QuoteResourceWrapper::class);

$this->quoteResourceWrapper = $quoteResourceWrapper;

engcom-Hotel · 2025-07-04T06:27:31Z

@magento run all tests

engcom-Hotel

Hello @KrasnoshchokBohdan,

Thanks for the collaboration!

The changes seems good to us, but please look into the below review comment.

Thanks

engcom-Hotel · 2025-07-04T08:18:48Z

+     * @param ResourceConnection $resourceConnection
+     */
+    public function __construct(
+        ResourceConnection $resourceConnection


Add readonly to class properties

…on-checkout pages - Refactor constructor to use readonly property promotion

engcom-Dash · 2025-07-15T10:25:47Z

@magento run all tests

engcom-Dash · 2025-07-17T08:38:50Z

@magento run all tests

engcom-Dash · 2025-07-17T11:25:49Z

@KrasnoshchokBohdan Thank you for contribution & collaboration!

✔️ QA Passsed

Preconditions:

Install fresh 2.4-develop
Install any profiling tool such as php-spx

Steps to reproduce:

Add product to cart from PLP
Go to the PDP page keeping profiler enabled
verified on two different PDP

Before: ❌

After: ✔️

I observed significant improvement in execution time. Previously, the operation took approximately 42ms-43ms, and after the PR changes, it took 1ms-2ms for CheckExpirePersistentQuoteObserver::execute.

The builds are failed hence moving this PR in Extended Testing.

engcom-Dash · 2025-07-17T11:34:15Z

@magento run Functional Tests B2B, Functional Tests CE

engcom-Dash · 2025-07-17T13:48:06Z

The Functional B2B Tests failures in the last two consecutive builds are not consistent. They neither failing because of the code changes done in this PR nor part of this PR.

Build 1: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39967/9f8d6c4fa147eb34fae7d2ddc8cc3355/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741

Build 2: https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/39967/223a2577e7607f816b69bcdc77ec64dd/Functional/allure-report-b2b/index.html#categories/bdbf199525818fae7a8651db9eafe741

Hence moving this PR in Merge In Progress.

engcom-Charlie · 2026-01-16T07:40:33Z

As there are conflicts in this PR, moving it to Changes Request. @KrasnoshchokBohdan can you please have a look into it and resolve the same.

engcom-Dash · 2026-02-16T07:59:20Z

Hello @KrasnoshchokBohdan,

We appreciate your contribution!

Since we haven't received a response from you for an extended period, we are closing this PR for now.
Whenever you're ready to resume work on this, please feel free to reopen it or request us to do so. We'll be more than happy to assist you.

Thanks once again!

magento#39948: Magento_Persistent performance overhead on non-cart, n…

b14e5d6

…on-checkout pages - new QuoteResourceWrapper class that uses direct SQL queries instead of loading the entire quote object, which should improve performance

Merge branch '2.4-develop' into fix-for-issue-39948

3ef112c

ihor-sviziev requested a review from Copilot June 6, 2025 09:30

ct-prd-projects-boards-automation Bot added the Progress: review label Jun 6, 2025

This comment was marked as outdated.

Sign in to view

KrasnoshchokBohdan added 3 commits June 6, 2025 16:28

magento#39948: Magento_Persistent performance overhead on non-cart, n…

b2de686

…on-checkout pages - static tests fix

magento#39948: Magento_Persistent performance overhead on non-cart, n…

fdff371

…on-checkout pages - unit tests

Merge remote-tracking branch 'origin/fix-for-issue-39948' into fix-fo…

dac25b3

…r-issue-39948

magento#39948: Magento_Persistent performance overhead on non-cart, n…

94eb707

…on-checkout pages - static tests

engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Jun 10, 2025

ct-prd-projects-boards-automation Bot added this to Pull Requests Dashboard Jun 10, 2025

github-project-automation Bot moved this to Pending Review in Pull Requests Dashboard Jun 10, 2025

ct-prd-projects-boards-automation Bot added the Progress: pending review label Jun 10, 2025

ihor-sviziev requested a review from Copilot June 11, 2025 09:07

ct-prd-projects-boards-automation Bot removed the Progress: pending review label Jun 11, 2025

ct-prd-projects-boards-automation Bot moved this from Pending Review to Review in Progress in Pull Requests Dashboard Jun 11, 2025

Copilot AI reviewed Jun 11, 2025

View reviewed changes

Merge branch '2.4-develop' into fix-for-issue-39948

3d07623

engcom-Hotel requested changes Jul 4, 2025

View reviewed changes

engcom-Hotel moved this from Review in Progress to Changes Requested in Pull Requests Dashboard Jul 4, 2025

ct-prd-projects-boards-automation Bot added Progress: needs update and removed Progress: review labels Jul 4, 2025

KrasnoshchokBohdan and others added 2 commits July 4, 2025 23:25

magento#39948: Magento_Persistent performance overhead on non-cart, n…

8f2439f

…on-checkout pages - Refactor constructor to use readonly property promotion

Merge branch '2.4-develop' into fix-for-issue-39948

45ff452

ct-prd-projects-boards-automation Bot added the Progress: ready for testing label Jul 10, 2025

engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Jul 10, 2025

engcom-Dash self-assigned this Jul 14, 2025

ct-prd-projects-boards-automation Bot added Progress: testing in progress and removed Progress: ready for testing labels Jul 14, 2025

ct-prd-projects-boards-automation Bot moved this from Ready for Testing to Testing in Progress in Pull Requests Dashboard Jul 14, 2025

engcom-Charlie added the Project: Community Picked PRs upvoted by the community label Jul 14, 2025

ct-prd-projects-boards-automation Bot added this to Community Dashboard Jul 14, 2025

ct-prd-projects-boards-automation Bot moved this to Testing in Progress in Community Dashboard Jul 14, 2025

ct-prd-projects-boards-automation Bot removed this from Pull Requests Dashboard Jul 14, 2025

Merge branch '2.4-develop' into fix-for-issue-39948

375d0d8

Merge branch '2.4-develop' into fix-for-issue-39948

19fa9f5

engcom-Dash moved this from Testing in Progress to Extended testing (optional) in Community Dashboard Jul 17, 2025

engcom-Dash added Progress: extended testing and removed Progress: testing in progress labels Jul 17, 2025

engcom-Dash moved this from Extended testing (optional) to Merge in Progress in Community Dashboard Jul 17, 2025

engcom-Dash removed the Progress: extended testing label Jul 17, 2025

sidolov added Partner: Perspective partners-contribution Pull Request is created by Magento Partner labels Jul 17, 2025

engcom-Charlie moved this from Merge in Progress to Changes Requested in Community Dashboard Jan 16, 2026

ct-prd-projects-boards-automation Bot added the Progress: needs update label Jan 16, 2026

engcom-Dash closed this Feb 16, 2026

ct-prd-projects-boards-automation Bot removed this from Community Dashboard Feb 16, 2026

		$this->quoteResourceWrapper = $quoteResourceWrapper ?: ObjectManager::getInstance()
		->get(QuoteResourceWrapper::class);

Conversation

KrasnoshchokBohdan commented Jun 6, 2025 • edited by ihor-sviziev Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant Bot commented Jun 6, 2025

Uh oh!

KrasnoshchokBohdan commented Jun 6, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

KrasnoshchokBohdan commented Jun 6, 2025

Uh oh!

KrasnoshchokBohdan commented Jun 7, 2025

Uh oh!

KrasnoshchokBohdan commented Jun 7, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

engcom-Hotel commented Jul 4, 2025

Uh oh!

engcom-Hotel left a comment

Choose a reason for hiding this comment

Uh oh!

engcom-Hotel Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

engcom-Dash commented Jul 15, 2025

Uh oh!

engcom-Dash commented Jul 17, 2025

Uh oh!

engcom-Dash commented Jul 17, 2025

✔️ QA Passsed

Uh oh!

engcom-Dash commented Jul 17, 2025

Uh oh!

engcom-Dash commented Jul 17, 2025

Uh oh!

engcom-Charlie commented Jan 16, 2026

Uh oh!

engcom-Dash commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

KrasnoshchokBohdan commented Jun 6, 2025 •

edited by ihor-sviziev

Loading